RFR: 8345471: Clean up compiler/intrinsics/sha/cli tests

Daniel Jeliński djelinski at openjdk.org
Thu Dec 12 06:59:35 UTC 2024


On Wed, 4 Dec 2024 20:06:19 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Merge all the GenericTestCaseForUnsupportedXXXCPU and GenericTestCaseForOtherCPU into GenericTestCaseForUnsupportedCPU.java.
>> 
>> The CPU-specific files are almost identical; I chose to resolve the differences in favor of the AArch64 version. The OtherCPU version looks wrong, and it wasn't executed on any supported platform.
>> 
>> The tests continue to pass on linux-aarch64/x64, windows-x64 and mac-aarch64. I didn't test other platforms.
>> 
>> After the change, the tests will start running on PPC and S390. They will also automatically run on any new architectures.
>> 
>> For those interested in historical background, when the tests were introduced, there were only 2 supported CPU architectures. X86 did not support any of the intrinsics, and the X86 test case did not even call `getPredicateForOption`. The call to `getPredicateForOption` was added in f2e9b827d699115f8683e9def06c249e5476fd50, and since then all the cases are the same.
>
> Good.

Thanks for the review @vnkozlov. Still waiting for a second reviewer...

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22517#issuecomment-2537965552


More information about the hotspot-compiler-dev mailing list