RFR: 8346174: UMAX/UMIN are missing from XXXVector::reductionOperations

Fri Dec 13 18:53:03 UTC 2024

On Fri, 13 Dec 2024 18:42:27 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

> Add functional support for unsigned min/max reductions on vectors.
> 
> We also need to ensure that the `reductionCoerced` intrinsic bails out when there is no reduction operation for the lanewise operation. When intrinsic support is added for integral vectors this will still be the case for floating point vectors.

LGTM otherwise.

@jatin-bhateja You may want to implement reduction intrinsics for these operations.

src/hotspot/share/opto/vectorIntrinsics.cpp line 1388:

> 1386:   int opc  = VectorSupport::vop2ideal(opr->get_con(), elem_bt);
> 1387:   int sopc = ReductionNode::opcode(opc, elem_bt);
> 1388:   if (sopc == opc) {

Can you merge this with the following `if`?

-------------

Marked as reviewed by qamai (Committer).

PR Review: https://git.openjdk.org/jdk/pull/22741#pullrequestreview-2502924424
PR Comment: https://git.openjdk.org/jdk/pull/22741#issuecomment-2542054187
PR Review Comment: https://git.openjdk.org/jdk/pull/22741#discussion_r1884349873