RFR: 8336356: [s390x] preserve Vector Register before using for string compress / expand [v2]

Amit Kumar amitkumar at openjdk.org
Sat Dec 14 11:24:39 UTC 2024


On Sat, 14 Dec 2024 10:26:48 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   suggestion from Andrew
>
> src/hotspot/cpu/s390/c2_MacroAssembler_s390.cpp line 187:
> 
>> 185:     VectorRegister Vzero      = v19;
>> 186:     VectorRegister Vsrc_first = v20;
>> 187:     VectorRegister Vsrc_last  = v23;
> 
> It would make more sense for the arguments to this function have names `Vtmp1`, `Vtmp2`, and so on. Rather than these aliases.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22354#discussion_r1885035403


More information about the hotspot-compiler-dev mailing list