RFR: 8336356: [s390x] preserve Vector Register before using for string compress / expand [v2]

Andrew Haley aph at openjdk.org
Sat Dec 14 18:35:41 UTC 2024


On Sat, 14 Dec 2024 11:09:32 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> This PR adds `TEMP` effect for the vector register, allotted by register allocator, used in the string compress/expand intrinsic. Also it enabled the Vector computation part of those intrinsics which was disabled by https://github.com/openjdk/jdk/pull/18162
>> 
>> tier1 test, which also includes string intrinsic tests `compiler/intrinsics/string/` are clean. No regression seen.
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   suggestion from Andrew

src/hotspot/cpu/s390/s390.ad line 10675:

> 10673:   ins_encode %{
> 10674:     __ string_compress($result$$Register, $src$$Register, $dst$$Register, $len$$Register,
> 10675:                        $tmp$$Register, true, false, $v16$$VectorRegister, $v17$$VectorRegister, $v18$$VectorRegister,

Fix indentation.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22354#discussion_r1885350415


More information about the hotspot-compiler-dev mailing list