RFR: 8336356: [s390x] preserve Vector Register before using for string compress / expand [v3]

Andrew Haley aph at openjdk.org
Sun Dec 15 13:11:37 UTC 2024


On Sun, 15 Dec 2024 02:51:21 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> This PR adds `TEMP` effect for the vector register, allotted by register allocator, used in the string compress/expand intrinsic. Also it enabled the Vector computation part of those intrinsics which was disabled by https://github.com/openjdk/jdk/pull/18162
>> 
>> tier1 test, which also includes string intrinsic tests `compiler/intrinsics/string/` are clean. No regression seen.
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   indentation fix in s390.ad file

That looks right. It's extremely difficult to be really sure that no mistakes have been made in the translation, but I think it's better than it was.

-------------

Marked as reviewed by aph (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22354#pullrequestreview-2504553592


More information about the hotspot-compiler-dev mailing list