RFR: 8332827: [REDO] C2: crash in compiled code because of dependency on removed range check CastIIs [v2]

[Emanuel Peter]

On Fri, 13 Dec 2024 13:09:17 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>>> Thanks for the updates, @rwestrel ! The fix looks reasonable. You can add an extra comment for the precedence edges for Div. I launched some testing now, feel free to ping me later.
>> 
>> Thanks for reviewing this. Would it be possible to run performance testing again? Performance testing was run for the initial fix (that was backed out) and this one is slightly different.
>
>> @rwestrel Ok, performance testing is launched. Please ping me again next week!
> 
> Thanks!

@rwestrel the performance testing looks good - though it is always hard to be 100% sure.

I see that this is now targetted for JDK24. Is that intentional or can we move it to JDK25?
Of course we want to backport it eventually, but maybe we can give it a little more time to see if performance drops due to this over JDK25, and the backport a little later. What do you think?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22568#issuecomment-2545085912