RFR: 8346289: Confusing phrasing in IR Framework README / User-defined Regexes

Christian Hagedorn chagedorn at openjdk.org
Tue Dec 17 07:19:37 UTC 2024


On Mon, 16 Dec 2024 15:39:32 GMT, theoweidmannoracle <duke at openjdk.org> wrote:

>> If such a user-defined regex represents a not yet supported C2 IR node, it is highly encouraged to directly add a new IR node placeholder string definition to IRNode for it instead together with a static regex mapping block.
> 
> The combination of "instead together" makes this sentence hard to read. I had to re-read it several times to grasp it.

Agreed, looks good!

-------------

Marked as reviewed by chagedorn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22766#pullrequestreview-2508027778


More information about the hotspot-compiler-dev mailing list