Integrated: 8346289: Confusing phrasing in IR Framework README / User-defined Regexes

theoweidmannoracle duke at openjdk.org
Tue Dec 17 10:04:41 UTC 2024


On Mon, 16 Dec 2024 15:39:32 GMT, theoweidmannoracle <duke at openjdk.org> wrote:

>> If such a user-defined regex represents a not yet supported C2 IR node, it is highly encouraged to directly add a new IR node placeholder string definition to IRNode for it instead together with a static regex mapping block.
> 
> The combination of "instead together" makes this sentence hard to read. I had to re-read it several times to grasp it.

This pull request has now been integrated.

Changeset: 5e25c48b
Author:    theoweidmannoracle <theo.weidmann at oracle.com>
Committer: Tobias Hartmann <thartmann at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/5e25c48b8bfe818816a9e8074f293dcab99b40ef
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8346289: Confusing phrasing in IR Framework README / User-defined Regexes

Reviewed-by: thartmann, chagedorn

-------------

PR: https://git.openjdk.org/jdk/pull/22766


More information about the hotspot-compiler-dev mailing list