RFR: 8346106: Verify.checkEQ: testing utility for recursive value verification [v2]

[Emanuel Peter]

On Wed, 18 Dec 2024 07:31:22 GMT, theoweidmannoracle <duke at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix exception text
>
> test/hotspot/jtreg/compiler/lib/verify/Verify.java line 93:
> 
>> 91:                 print(a, "a " + context);
>> 92:                 print(b, "b " + context);
>> 93:                 throw new VerifyException("Object array type not supported: " + ca.getName());
> 
> This pattern repeats 3 times here and also below. Maybe you want to consider to move it to a `reportError(String message, String details, a, b, context)` method?

It does repeat somewhat, but not really identically. With different types for a, sometimes with context, sometimes without. Feel free to add code suggestions, because I'm not sure what you are exactly imagining.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22715#discussion_r1889985813