RFR: 8346107: Generators: testing utility for random value generation

Emanuel Peter epeter at openjdk.org
Wed Dec 18 12:14:40 UTC 2024


On Wed, 18 Dec 2024 10:30:26 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/lib/generators/SpecialDoubleGenerator.java line 56:
>> 
>>> 54:     private int specialCountDown;
>>> 55: 
>>> 56:     public SpecialDoubleGenerator(DoubleGenerator backgroundGenerator, int specialMinFrequency, int specialMaxFrequency) {
>> 
>> I think it would be nice to a brief description of what the specialMin/MaxFrequency parameters mean exactly. Also for the float version.
>
> Ok, will do.

I now added documentation everywhere, so that `javadocs` does not complain any more. Thanks for the hint!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22716#discussion_r1890137718


More information about the hotspot-compiler-dev mailing list