RFR: 8346107: Generators: testing utility for random value generation [v2]

[Emanuel Peter]

On Wed, 18 Dec 2024 07:58:35 GMT, theoweidmannoracle <duke at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - use Generators.Random, rm some imports
>>  - rm whitespace
>>  - Extra documentation, and review suggestions v1
>
> test/hotspot/jtreg/compiler/lib/generators/AnyBitsDoubleGenerator.java line 34:
> 
>> 32:  */
>> 33: public final class AnyBitsDoubleGenerator extends DoubleGenerator {
>> 34:     private static final Random RANDOM = Utils.getRandomInstance();
> 
> Would it make sense to use the definition Generators.RANDOM everywhere instead of having this definition in every generator class?

good idea. Also removes the Random and Utils import. Very nice

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22716#discussion_r1890151812