RFR: 8331717: C2: Crash with SIGFPE Because Loop Predication Wrongly Hoists Division Requiring Zero Check [v2]

[theoweidmannoracle]

On Tue, 17 Dec 2024 12:10:21 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

> It seems strange to me that a DivINode here has the property depends_only_on_test but its control input is an unrelated test.

I think that's fine. After all, depends_only_on_test indicates that

>  If this node is control-dependent on a test, can it be rerouted to a dominating equivalent test? 

which is absolutely true for division and was also correctly used by the IGVN transformation. 

The source of the problem here is really with the way Invariance works.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22666#issuecomment-2551236889