RFR: 8332827: [REDO] C2: crash in compiled code because of dependency on removed range check CastIIs [v4]
Roland Westrelin
roland at openjdk.org
Wed Dec 18 16:40:56 UTC 2024
> The failures that caused the backout were due to a bug in:
>
> `find_or_make_integer_cast()`
>
> which caused the `_range_check_dependency` field's value of the
> existing cast node to not be set in the new cast node. I re-ran some
> testing with this fixed and current jdk repo and found that a few
> vectorization tests fail now because the patch pushes range check
> `CastII` nodes through `AddI`/`SubI`. To fix this, I delayed that
> transformation to after loop opts.
Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
review
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/22568/files
- new: https://git.openjdk.org/jdk/pull/22568/files/2aa63d52..6d32afaa
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=22568&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=22568&range=02-03
Stats: 7 lines in 4 files changed: 1 ins; 2 del; 4 mod
Patch: https://git.openjdk.org/jdk/pull/22568.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/22568/head:pull/22568
PR: https://git.openjdk.org/jdk/pull/22568
More information about the hotspot-compiler-dev
mailing list