RFR: 8346106: Verify.checkEQ: testing utility for recursive value verification [v3]

theoweidmannoracle duke at openjdk.org
Thu Dec 19 08:06:22 UTC 2024


On Thu, 19 Dec 2024 08:03:29 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> In testing, we often generate "golden" values, and then compare the results with it. This requires comparison loops etc in every test. I would like to create a dedicated facility for this, to simplify testing in the future. This is also preparation for [JDK-8344942](https://bugs.openjdk.org/browse/JDK-8344942), the Template framework.
>> 
>> I have written code like this in various tests before, see:
>> `test/hotspot/jtreg/compiler/loopopts/superword/TestAlignVectorFuzzer.java`
>> `./test/hotspot/jtreg/compiler/loopopts/superword/TestMemorySegment.java`
>> `test/hotspot/jtreg/compiler/loopopts/superword/TestIndependentPacksWithCyclicDependency.java`.
>> 
>> It is now time to make a proper facility, so I can save time when writing tests in the future.
>> 
>> A related PR, for value generation: https://github.com/openjdk/jdk/pull/22716
>
> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   improve documentation

Looks good to me!

-------------

Marked as reviewed by theoweidmannoracle at github.com (no known OpenJDK username).

PR Review: https://git.openjdk.org/jdk/pull/22715#pullrequestreview-2513609200


More information about the hotspot-compiler-dev mailing list