RFR: 8323220: Reassociate loop invariants involved in Cmps and Add/Subs [v5]

[Joshua Cao]

On Thu, 25 Jan 2024 09:25:56 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Joshua Cao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   reassociate_add_sub -> reassociate_add_sub_cmp
>
> Tests pass, thanks for the updates.
> I left a few optional comments.
> 
> One requiest I would still like to see:
> You could improve the tests, by returning a value that indicates when the loop was exited, i.e. `return i`. In the future, I intend to verify the return values from test methods, and then we would have additional coverage for free ;)
> 
> @caojoshua Update: you can actually already do result verification, with the `@check` method. Can you please add that?

failure is due to mac infra issues and not related to test. @eme64 do the @check's look ok?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17375#issuecomment-1920232555