RFR: 8324641: [IR Framework] Add Setup method to provide custom arguments and set fields [v2]

Emanuel Peter epeter at openjdk.org
Mon Feb 5 13:54:22 UTC 2024


On Mon, 5 Feb 2024 12:06:45 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   for Review by Christian
>>   
>>   Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>
> test/hotspot/jtreg/compiler/lib/ir_framework/Setup.java line 34:
> 
>> 32:  * {@link Arguments} annotation. A setup method can optionally take a {@link SetupInfo} as an argument. The for the
>> 33:  * arguments for the test methods are returned in an Object[].
>> 34:  *
> 
> Maybe also add a hint how to use it similar to what's found at `@Test`:
> 
> 
> Examples on how to use test methods can be found in {@link ir_framework.examples.SetupExample} and also as part of the internal testing in the package {@link ir_framework.tests}.

done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17557#discussion_r1478286951


More information about the hotspot-compiler-dev mailing list