RFR: 8317349: Randomize order of macro node expansion in C2 [v2]

Daniel Lundén dlunden at openjdk.org
Mon Feb 5 15:54:02 UTC 2024


On Mon, 5 Feb 2024 14:30:09 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Remove flag from some test cases
>>  - Updates after Christian's comments
>
> That's a nice stress option! I have a few comments.

Thanks @chhagedorn and @robcasloz. I made the trivial changes suggested by Christian, so the remaining question is how to handle dump levels and what/when to dump.

My suggestion: set dump levels to 5 for now, as Christian suggests, but do not yet add any dumps to `eliminate_macro_nodes`. I'll create a separate RFE with Roberto's suggestion (which I think sounds good and, looking at the code, quite easy to achieve through a bit of restructuring) together with IGV dumping for macro elimination. What do you think?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17684#issuecomment-1927307856


More information about the hotspot-compiler-dev mailing list