RFR: 8324641: [IR Framework] Add Setup method to provide custom arguments and set fields [v6]
Emanuel Peter
epeter at openjdk.org
Tue Feb 6 11:14:15 UTC 2024
On Mon, 5 Feb 2024 15:36:09 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>>
>> fix more comments
>
> Thanks for the updates. I will have a closer look again at the README tomorrow but the code changes look good.
>
> What's missing are some good and bad tests that use the new features. `SetupExample.java` already provides some good working examples and maybe that's sufficient. Maybe you can double check if it's worth to add some more good (i.e. non-failing) tests.
>
> The bad tests can be added to `TestBadFormat` which should include things like a `@Setup` test without a corresponding `@Test` method, mixing `setup` and `value` etc. Can you add some of these bad tests?
@chhagedorn thanks for reviewing! Yes, I will add some more tests 😊
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17557#issuecomment-1929292221
More information about the hotspot-compiler-dev
mailing list