RFR: 8324641: [IR Framework] Add Setup method to provide custom arguments and set fields [v7]
Emanuel Peter
epeter at openjdk.org
Tue Feb 6 15:21:19 UTC 2024
On Tue, 6 Feb 2024 14:25:48 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> Emanuel Peter has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - fix whitespace from last commit
>> - Apply suggestions from code review
>>
>> Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>
> test/hotspot/jtreg/compiler/lib/ir_framework/README.md line 57:
>
>> 55:
>> 56: #### Custom Run Tests
>> 57: The normal test method is invoked directly by the framework, and hence the user does not have control over the invokation.
>
> This was probably copy pasted here by mistake since it's a description of a normal test.
> Suggestion:
It was to mirror the old description of Custom Run Test:
"Neither the base nor the checked tests provide any control over..."
"A custom run test gives full control..."
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17557#discussion_r1480013469
More information about the hotspot-compiler-dev
mailing list