RFR: 8324641: [IR Framework] Add Setup method to provide custom arguments and set fields [v7]

[Emanuel Peter]

On Tue, 6 Feb 2024 14:13:26 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - fix whitespace from last commit
>>  - Apply suggestions from code review
>>    
>>    Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>
> test/hotspot/jtreg/compiler/lib/ir_framework/README.md line 44:
> 
>> 42: Arguments can be provided with `@Arguments(values = {...})` by providing well-specified inputs for each individual argument. Alternatively, a setup method can be chosen with `@Arguments(setup = "setupMethodName")`, which computes arguments and can also set fields.
>> 43: 
>> 44: More information on normal test methods with a precise definition can be found in the Javadocs of [Test](./Test.java). Concrete examples on how to specify a normal test can be found in [BaseTestsExample](../../../testlibrary_tests/ir_framework/examples/BaseTestExample.java).
> 
> Since we now change the README and the definition of two kinds of tests, I also suggest to rename `BaseTestExample.java` to `NormalTestExample.java`.

done

> test/hotspot/jtreg/compiler/lib/ir_framework/README.md line 54:
> 
>> 52: A `@Check` annotated method is invoked directly after a corresponding normal `@Test` annotated method. The user can perform various checks, such as test method return value and field value verification.
>> 53: 
>> 54: More information on check methods with a precise definition can be found in the Javadocs of [Check](./Check.java). Concrete examples on how to specify check methods can be found in [CheckedTestsExample](../../../testlibrary_tests/ir_framework/examples/CheckedTestExample.java).
> 
> Maybe add here an additional paragraph:
> 
> `@Setup` and `@Check` methods can only be specified for normal but not for custom run tests (see next section).

done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17557#discussion_r1480036398
PR Review Comment: https://git.openjdk.org/jdk/pull/17557#discussion_r1480040034