RFR: 8323220: Reassociate loop invariants involved in Cmps and Add/Subs [v6]

[Joshua Cao]

On Thu, 1 Feb 2024 06:57:13 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Joshua Cao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Small fixes and add check methods for tests
>
> test/hotspot/jtreg/compiler/loopopts/InvariantCodeMotionReassociateCmp.java line 115:
> 
>> 113:             }
>> 114:         }
>> 115:     }
> 
> I suggest you add a test that first iterates some number of iterations, and then returns inside the if-statement with return value i. Then you check if that value is as expected.
> Because with all the tests that you have here, I'm not sure if really all branches are always taken, or if they may lead to uncommon traps, and hence leave some things uncovered by testing.

@eme64 can you take a look at the updates?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17375#discussion_r1480399765