RFR: 8323274: C2: array load may float above range check [v2]

[Roland Westrelin]

On Wed, 7 Feb 2024 09:03:14 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request incrementally with five additional commits since the last revision:
>> 
>>  - Update src/hotspot/share/opto/arraycopynode.cpp
>>    
>>    Co-authored-by: Emanuel Peter <emanuel.peter at oracle.com>
>>  - Update src/hotspot/share/opto/loopopts.cpp
>>    
>>    Co-authored-by: Emanuel Peter <emanuel.peter at oracle.com>
>>  - Update src/hotspot/share/opto/loopopts.cpp
>>    
>>    Co-authored-by: Emanuel Peter <emanuel.peter at oracle.com>
>>  - Update src/hotspot/share/opto/split_if.cpp
>>    
>>    Co-authored-by: Emanuel Peter <emanuel.peter at oracle.com>
>>  - Update src/hotspot/share/opto/split_if.cpp
>>    
>>    Co-authored-by: Emanuel Peter <emanuel.peter at oracle.com>
>
> test/hotspot/jtreg/compiler/rangechecks/TestArrayAccessAboveRCAfterSinking.java line 55:
> 
>> 53:             test1(allTrue, array, -1, true, 0);
>> 54:             test2(allTrue, array, -1, true, 0);
>> 55:         } catch (ArrayIndexOutOfBoundsException arrayIndexOutOfBoundsException) {
> 
> Is there a reason both are together in the same `try-catch` block? It seems like if the first throws, then the second is never executed (and may as well be removed), or we only expect the second to throw, and so the first one should be outside the bock. What do you think?

You're right. I will change that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17635#discussion_r1481451200