RFR: JDK-8325432: enhance assert message "relocation addr must be in this section"

[Vladimir Kozlov]

On Wed, 7 Feb 2024 14:08:48 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> The assert message "relocation addr must be in this section" in codeBuffer.hpp could be enhanced by printing the pointer and section information.
> See also
> https://bugs.openjdk.org/browse/JDK-8325326
> 8325326: compiler/codecache/TestStressCodeBuffers.java assertion on AIX
> 
> where we run into the assertion since 2 days.

Marked as reviewed by kvn (Reviewer).

src/hotspot/share/asm/codeBuffer.hpp line 212:

> 210:   void    set_locs_point(address pc) {
> 211:     assert(pc >= locs_point(), "relocation addr may not decrease");
> 212:     assert(allocates2(pc),     "relocation addr " INTPTR_FORMAT " must be in this section from " INTPTR_FORMAT " to " INTPTR_FORMAT, p2i(pc), p2i(_start), p2i(_limit));

Good.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17749#pullrequestreview-1868693191
PR Review Comment: https://git.openjdk.org/jdk/pull/17749#discussion_r1482025211