RFR: 8325438: Add exhaustive tests for Math.round intrinsics
Christian Hagedorn
chagedorn at openjdk.org
Thu Feb 8 08:21:58 UTC 2024
On Wed, 7 Feb 2024 16:07:02 GMT, Hamlin Li <mli at openjdk.org> wrote:
> HI,
> Can you have a look at this patch adding some tests for Math.round instrinsics?
> Thanks!
>
> ### FYI:
> During the development of RoundVF/RoundF, we faced the issues which were only spotted by running test exhaustively against 32/64 bits range of int/long.
> It's helpful to add these exhaustive tests in jdk for future possible usage, rather than build it everytime when needed.
> Of course, we need to put it in `manual` mode, so it's not run when `-automatic` jtreg option is specified which I guess is the mode CI used, please correct me if I'm assume incorrectly.
It's good to add some tests for that. Have you considered using IR tests instead? This could simplify the test and result verification and also add the benefit of sanity checking whether we actually used the intrinsic with matching `RoundD` in the IR, for example.
With https://github.com/openjdk/jdk/pull/17557, which will probably soon be integrated, you can also do an easier setup of the test method arguments.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17753#issuecomment-1933568394
More information about the hotspot-compiler-dev
mailing list