RFR: 8324641: [IR Framework] Add Setup method to provide custom arguments and set fields [v16]

[Emanuel Peter]

On Thu, 8 Feb 2024 07:38:21 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - remove tabs
>>  - improved and simplified examples
>
> test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestBadFormat.java line 655:
> 
>> 653:     public void badSetupRunAnnotation() {}
>> 654: 
>> 655:     // ----------- Ok: Setup Without Test Method -----------------
> 
> Maybe change this to "Useless but ok". Maybe we still want to add some verification for these useless methods. But let's do that separately.

will do

> test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestSetupTests.java line 235:
> 
>> 233:     @Test
>> 234:     @Arguments(setup = "setupTooFewArgs")
>> 235:     public void testTooFewArgs(int a, int b, int c) {}
> 
> We should also test:
> - Wrongly returning an empty Object array where we expect at least one argument
> - Having a `@Setup` method even though the `@Test` method takes no arguments.
> 
> But I might have missed that you already provided such tests .

will do

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17557#discussion_r1482722920
PR Review Comment: https://git.openjdk.org/jdk/pull/17557#discussion_r1482722738