RFR: 8324641: [IR Framework] Add Setup method to provide custom arguments and set fields [v19]

[Tobias Hartmann]

On Thu, 8 Feb 2024 11:50:43 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> **Bigger goal**
>> 
>> I am tired of always writing IR tests where I have to write elaborate code in the `@Run` method to create inputs, and then run the test method to create `gold` output values in (hopefully) interpreter mode, and then later verify the results of the compiled method.
>> 
>> Hence, I now introduce the "Setup" method, which can create custom argument values.
>> In a later RFE, I will implement automatic result verification, which implicitly intercepts the inputs and outputs of the test method, and compares the behaviour of the interpreter and the compiled code. That way, the pattern will be:
>> 
>> 
>> @Setup
>> ... specify your arguments and fields ...
>> 
>> -> intercept arguments, cache them
>> 
>> @Test
>> ... write a test with arbitrary inputs and outputs...
>> 
>> -> interpreter mode: intercept outputs and cache them (i.e. gold values)
>> -> compiled mode: intercept outputs and compare them to the gold values.
>> 
>> (optional)
>> @Check
>> .. do custom verification...
>> 
>> 
>> **In this RFE: the Setup Method**
>> 
>> The first step is the setup method.
>> 
>> Example:
>> https://github.com/openjdk/jdk/blob/08670a5d45b1c45e954e2dc85eb8c92e11e48fb2/test/hotspot/jtreg/testlibrary_tests/ir_framework/examples/SetupExample.java#L49-L87
>
> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix whitespace

Very nice. The changes look good to me.

-------------

Marked as reviewed by thartmann (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17557#pullrequestreview-1870597429