RFR: 8325541: C2 SuperWord: refactor filter / split [v6]

Vladimir Kozlov kvn at openjdk.org
Mon Feb 12 18:10:57 UTC 2024


On Mon, 12 Feb 2024 17:38:46 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> @eme64 did you consider creating inner class (for SuperWord class) which do all these operations? I am for verbose names but repeated `filter_packs_` prefix is bothering me.
>
> @vnkozlov how would such an inner class look like?
> 
> I'm not yet 100% happy with how the list of `filter_packs_...` looks like. See conversation with Christian: https://github.com/openjdk/jdk/pull/17785#discussion_r1484365725
> 
> But I will refactor more around that code soon: I will probably turn some of the filters into split operations (e.g. split if only implemented for smaller vector width, or if dependency blocks vectorization at current vector with but not at a smaller one, etc). For that reason, I'd like to just have the big "laundry-list", and then put things in a nicer shape once all the refactorings have stabilized. Would that be ok?

@eme64 Okay since you have plans to improve it.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17785#issuecomment-1939268082


More information about the hotspot-compiler-dev mailing list