RFR: 8324969: assert(false) failed: Non-balanced monitor enter/exit! [v4]

[Dean Long]

On Wed, 14 Feb 2024 00:04:47 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

> > Is there a reason the above check can't be done as part of coarsened_locks_consistent()?
> 
> `Unbalanced` in coarsened_locks_consistent() is different from `Unbalanced` in `mark_coarsened_boxes()` Or do you mean to recompile without lock coarsening when regions are unbalanced? But that will disable all coarsening, even valid one (for example, when no outer locking in my examples).

If we are simply making sure that all nodes in a group have the same BoxLock, then that check could be done earlier, in coarsened_locks_consistent(), or even as the nodes are added to the list.  But I guess it's possible to get a premature answer is nodes are removed from the list.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17697#discussion_r1488762687