RFR: 8325746: Refactor Loop Unswitching code [v2]

[Christian Hagedorn]

On Wed, 14 Feb 2024 11:04:06 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> src/hotspot/share/opto/loopopts.cpp line 2871:
>> 
>>> 2869:   assert(opcode == Op_If || opcode == Op_RangeCheck, "unexpected opcode");
>>> 2870:   IfNode* new_if = (opcode == Op_If) ? new IfNode(proj2, bol, iff->_prob, iff->_fcnt):
>>> 2871:     new RangeCheckNode(proj2, bol, iff->_prob, iff->_fcnt);
>> 
>> Since I re-used this pattern again, I extracted this into `make_with_same_profile()`.
>
> Do you want to take over the assert as well?

I think it should now be covered with the additional assert in `make_with_same_profile()`. If we pass something else, we will hit that assert.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17842#discussion_r1489342700