RFR: 8324969: C2: prevent elimination of unbalanced coarsened locking regions [v5]

Vladimir Kozlov kvn at openjdk.org
Wed Feb 14 19:47:04 UTC 2024


On Wed, 14 Feb 2024 09:45:42 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Vladimir Kozlov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Additional changes
>
> Drive-by suggestion: Can we name the bug mention what is being done, rather than a symptom? Thanks!

> @shipilev people have different philosophies about that, it seems. Is there a "style guiede" for that? I prefer "what is being done" too. Makes it easier when browsing through the "git blame" later.
> 
> Suggestion: `C2: prevent elimination of unballanced coarsened lock boxes`

Good suggestion. I replace `boxes` with `regions`. That is what I used in code comments.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17697#issuecomment-1944481415


More information about the hotspot-compiler-dev mailing list