RFR: 8325326: compiler/codecache/TestStressCodeBuffers.java assertion on AIX

[Martin Doerr]

On Wed, 14 Feb 2024 12:02:29 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

> Hi, as I understand, this is not only a fix, but by changing from allocate_* to constant_* it reuses entries in the oop_recorder. I.e., if the same object is presented twice, the same index is returned now. Before, it had different indicees. Is this intended?

Yes. When we use the same oop constant several times, we should better share the TOC slot for efficiency reasons (space and GC overhead). We're doing this already at other places. And also for metadata. Seems like the 2 usages had been forgotten when making improvements. The allocate_* versions are only needed when we want to replace the object by a different one, typically null by the desired object.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17744#issuecomment-1945331331