RFR: 8325746: Refactor Loop Unswitching code [v4]

Christian Hagedorn chagedorn at openjdk.org
Thu Feb 15 08:51:08 UTC 2024


On Wed, 14 Feb 2024 14:40:07 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change block -> path
>
> Thanks for the updates, we are almost there :)

Thanks @eme64 and @vnkozlov for your reviews! I've addressed your latest comments.

About the long lines: I'm using 120 chars by default which fits nicely on the screen in the IDE and is also the default suggested by the IDE. But I guess that's also a matter of taste. Unfortunately, our style guide also does not mention anything about it - maybe because it's a personal preference. But anyway, I agree that some comments were a bit too densely packed. I've updated them according to your suggestions. Let me know if there are other comments that you think should be updated as well.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17842#issuecomment-1945622579


More information about the hotspot-compiler-dev mailing list