RFR: 8320649: C2: Optimize scoped values [v7]

Roland Westrelin roland at openjdk.org
Thu Feb 15 16:55:02 UTC 2024


On Thu, 8 Feb 2024 13:00:59 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains ten commits:
>> 
>>  - review comment
>>  - Merge branch 'master' into JDK-8320649
>>  - Update src/hotspot/share/opto/callGenerator.cpp
>>    
>>    Co-authored-by: Emanuel Peter <emanuel.peter at oracle.com>
>>  - Update test/hotspot/jtreg/compiler/c2/irTests/TestScopedValue.java
>>    
>>    Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>>  - merge fix
>>  - Merge branch 'master' into JDK-8320649
>>  - test failures
>>  - white spaces + bug id in test
>>  - test & fix
>
> src/hotspot/share/opto/callGenerator.cpp line 1089:
> 
>> 1087:   // that some paths may end with an uncommon trap and if one traps, we want the trap to be recorded for the right bci.
>> 1088:   // When the ScopedValueGetHitsInCache/ScopedValueGetLoadFromCache pair is expanded, split if finds the duplicate
>> 1089:   // logic and cleans it up.
> 
> Do we have an IR test for that?

We have 2: `testFastPath13` and `testSlowPath9`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16966#discussion_r1491328069


More information about the hotspot-compiler-dev mailing list