RFR: 8323220: Reassociate loop invariants involved in Cmps and Add/Subs [v10]

[Emanuel Peter]

On Fri, 16 Feb 2024 07:20:38 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Joshua Cao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:
>> 
>>  - Update test to utilize @setup method for arguments
>>  - Merge branch 'master' into licm
>>  - Add correctness test for some random tests with random inputs
>>  - Add some correctness tests where we do reassociate
>>  - Remove unused TestInfo parameter. Have some tests exit mid-loop.
>>  - Merge branch 'master' into licm
>>  - Small fixes and add check methods for tests
>>  - reassociate_add_sub -> reassociate_add_sub_cmp
>>  - Formatting and fix typo
>>  - Assert for n2. Variables for n1/n2 opcode. More concise comments.
>>    Overflow/random tests
>>  - ... and 2 more: https://git.openjdk.org/jdk/compare/dca35b21...ad073ef2
>
> test/hotspot/jtreg/compiler/loopopts/InvariantCodeMotionReassociateCmp.java line 71:
> 
>> 69:         }
>> 70:         return new Object[] { inv1, inv2 };
>> 71:     }
> 
> Suggestion:
> 
>     }

Have a free newline between methods

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17375#discussion_r1492046093