RFR: 8325610: CTW: Add StressIncrementalInlining to stress options

Aleksey Shipilev shade at openjdk.org
Mon Feb 19 09:32:55 UTC 2024


On Fri, 16 Feb 2024 22:08:27 GMT, Joshua Cao <duke at openjdk.org> wrote:

> CtwRunner opts-in into [various C2 randomizers](https://github.com/openjdk/jdk/blob/6a12362660d6221beb3a059dc90d06a8068cce39/test/hotspot/jtreg/testlibrary/ctw/src/sun/hotspot/tools/ctw/CtwRunner.java#L297-L301)
> 
> I think we forgot to add -XX:+StressIncrementalInlining there, which was added by [JDK-8319879](https://bugs.openjdk.org/browse/JDK-8319879).
> 
> tested by `./ctwrunner.sh modules:java.base`
> 
> I can see `-XX:+StressIncrementalInlining` in `modules_java_base_0.cmd`
> 
> 
> -Xbatch
> -XX:-ShowMessageBoxOnError
> -XX:+UnlockDiagnosticVMOptions
> -XX:+DisplayVMOutputToStderr
> -DCompileTheWorldStartAt=0
> -DCompileTheWorldStopAt=7671
> -XX:+WhiteBoxAPI
> -Xbootclasspath/a:.
> --add-exports
> java.base/jdk.internal.jimage=ALL-UNNAMED
> --add-exports
> java.base/jdk.internal.misc=ALL-UNNAMED
> --add-exports
> java.base/jdk.internal.reflect=ALL-UNNAMED
> --add-exports
> java.base/jdk.internal.access=ALL-UNNAMED
> -XX:+LogCompilation
> -XX:LogFile=hotspot_modules_java_base_0_%p.log
> -XX:ErrorFile=hs_err_modules_java_base_0_%p.log
> -XX:ReplayDataFile=replay_modules_java_base_0_%p.log
> -XX:CompileCommand=exclude,java/lang/invoke/MethodHandle.*
> -XX:+IgnoreUnrecognizedVMOptions
> -XX:+StressLCM
> -XX:+StressGCM
> -XX:+StressIGVN
> -XX:+StressCCP
> -XX:+StressMacroExpansion
> -XX:+StressIncrementalInlining
> -XX:StressSeed=1785134692
> 
> sun.hotspot.tools.ctw.CompileTheWorld
> modules:java.base

Good.

test/hotspot/jtreg/testlibrary/ctw/src/sun/hotspot/tools/ctw/CtwRunner.java line 302:

> 300:                 "-XX:+StressCCP",
> 301:                 "-XX:+StressMacroExpansion",
> 302:                 "-XX:+StressIncrementalInlining",

I think we want to maintain the historical order here. Check me on this: `StressIncrementalInlining` went in before `StressMacroExpansion`, but after `StressCCP`, and so should be one line up?

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17897#pullrequestreview-1887946001
PR Review Comment: https://git.openjdk.org/jdk/pull/17897#discussion_r1494250391


More information about the hotspot-compiler-dev mailing list