RFR: 8326135: Enhance adlc to report unused operands [v2]

kuaiwei duke at openjdk.org
Wed Feb 21 02:52:01 UTC 2024


On Tue, 20 Feb 2024 17:07:59 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> kuaiwei has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add newline in report
>
> src/hotspot/share/adlc/archDesc.cpp line 739:
> 
>> 737:   callback.do_form_by_name("stackSlotL");
>> 738: 
>> 739:   // special generic vector operands used in Matcher::pd_specialize_generic_vector_operand
> 
> What is special about `stackSlot*` and `vec*` operands to process them explicitly here?

stackSlot* are used in output_h.cpp and formssel.cpp . I assume they are all useful.

Generic vector operands are not used in instruction forms. But they are used in c++ code snippet Matcher::pd_specialize_generic_vector_operand(). The special vector operands only exists in x86_64 and aarch64 platform.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17910#discussion_r1496808944


More information about the hotspot-compiler-dev mailing list