RFR: 8324655: Identify integer minimum and maximum patterns created with if statements [v2]

[Jasmine Karthikeyan]

On Wed, 7 Feb 2024 09:37:19 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Jasmine Karthikeyan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Don't transform highly predictable branches
>
> src/hotspot/share/opto/cfgnode.cpp line 1788:
> 
>> 1786:   IfNode* iff = region->in(1)->in(0)->as_If();
>> 1787:   BoolNode* bol = iff->in(1)->as_Bool();
>> 1788:   Node* cmp = bol->in(1);
> 
> Could some of these values be const, or even TOP?

I don't think these values can be TOP here as `PhiNode::is_diamond_phi()` and `RegionNode::is_diamond()`, which are called before this method is called, check to make sure that these nodes have the correct types and are not TOP.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17574#discussion_r1499552793