RFR: 8326524: Rename agent_common.h
Dean Long
dlong at openjdk.org
Fri Feb 23 02:09:55 UTC 2024
On Thu, 22 Feb 2024 19:38:26 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
> Please review this trivial change that renames the file
> test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/agent_common/agent_common.h to
> agent_common.hpp.
>
> The #include updates were performed mechanically, and builds would fail if
> there were mistakes.
>
> The copyright updates were similarly performed mechanically. All but a handful
> of the including files have already had their copyrights updated recently,
> likely as part of JDK-8324681. The only change to the renamed file is a
> copyright update, since no code changes were required.
>
> Testing: mach5 tier1
If we wanted to minimize changes, we could have agent_common.h include agent_common.hpp. Then we don't have to change all the .cpp files, which have other problems, like the includes not being sorted.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17970#issuecomment-1960638558
More information about the hotspot-compiler-dev
mailing list