RFR: 8325144: C1: Optimize CriticalEdgeFinder [v5]

Christian Hagedorn chagedorn at openjdk.org
Mon Feb 26 09:28:02 UTC 2024


On Tue, 20 Feb 2024 05:44:09 GMT, Denghui Dong <ddong at openjdk.org> wrote:

>> Hi,
>> 
>> Please help review this change that removed the sorting process in split_edges by checking if the 'to' block has been substituted.
>> 
>> Thanks
>
> Denghui Dong has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update copyright

Looks good!

> The functionality of CriticalEdgeFinder is to insert a new block between the two blocks which satisfy the following conditions:

While at it, maybe you also want to add a concise summary as a comment for the `CriticalEdgeFinder` class.

-------------

Marked as reviewed by chagedorn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17674#pullrequestreview-1900350012


More information about the hotspot-compiler-dev mailing list