RFR: 8320649: C2: Optimize scoped values [v4]

[Emanuel Peter]

On Wed, 17 Jan 2024 10:05:47 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   merge fix
>
> src/hotspot/share/opto/callGenerator.cpp line 1193:
> 
>> 1191:     // continue:
>> 1192:     //
>> 1193:     // slow_call:
> 
> Makes it look like continue is a fall-through to slow_call, that is not what you want, right?

Thanks for the update ✔

> src/hotspot/share/opto/callGenerator.cpp line 1225:
> 
>> 1223:     // that some paths may end with an uncommon trap and if one traps, we want the trap to be recorded for the right bci.
>> 1224:     // When the ScopedValueGetHitsInCache/ScopedValueGetLoadFromCache pair is expanded, split if finds the duplicate
>> 1225:     // logic and cleans it up.
> 
> I would prefer the comment section at the beginning of the method. Otherwise I may start reading down linearly, reverse-engineer the code, and only discover this afterwards... 😅

Thanks for the updates ✔

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16966#discussion_r1502708977
PR Review Comment: https://git.openjdk.org/jdk/pull/16966#discussion_r1502711817