RFR: 8324655: Identify integer minimum and maximum patterns created with if statements [v3]

Jasmine Karthikeyan jkarthikeyan at openjdk.org
Mon Feb 26 14:59:01 UTC 2024


On Mon, 26 Feb 2024 10:08:13 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Jasmine Karthikeyan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Merge master
>>  - Apply changes from review
>>  - Don't transform highly predictable branches
>>  - Convert integer min/max patterns to Min/Max nodes
>
> test/hotspot/jtreg/compiler/c2/irTests/TestIfMinMax.java line 36:
> 
>> 34:  * @summary Test that if expressions are properly folded into min/max nodes
>> 35:  * @library /test/lib /
>> 36:  * @requires vm.compiler2.enabled
> 
> Is this necessary to require C2? As far as I know, the IR framework just won't do IR verification. But it would still be nice to have the correctness checks for other compilers (e.g. C1).

Ah, I wasn't aware that the IR framework could run in that fashion, I will change it to remove that line.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17574#discussion_r1502747988


More information about the hotspot-compiler-dev mailing list