RFR: 8325681: C2 inliner rejects to inline a deeper callee because the methoddata of caller is immature. [v2]
Xin Liu
xliu at openjdk.org
Tue Feb 27 07:07:45 UTC 2024
On Mon, 26 Feb 2024 22:05:44 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:
>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update the comment.
>
> test/hotspot/jtreg/compiler/c2/irTests/TestUnderProfiledSubprocedure.java line 61:
>
>> 59: Object[] setupCondition() {
>> 60: // return true with ODD% possibility.
>> 61: return new Object[]{Boolean.valueOf(RANDOM.nextInt(100) < ODD)};
>
> Why don't you produce a deterministic sequence with desired distribution instead?
> Random input data generation may be a source of intermittent test failures.
> E.g., what are the chances that condition will never be true?
> (It's the first time I see `@Setup` usage, so I have a hard time reasoning about its behavior.)
you mean I create a pattern such as 10-length array '10000 00000' and repeat it?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17957#discussion_r1503732196
More information about the hotspot-compiler-dev
mailing list