RFR: 8325144: C1: Optimize CriticalEdgeFinder [v6]

[Christian Hagedorn]

On Mon, 26 Feb 2024 15:03:07 GMT, Denghui Dong <ddong at openjdk.org> wrote:

>> Hi,
>> 
>> Please help review this change that removed the sorting process in split_edges by checking if the 'to' block has been substituted.
>> 
>> Thanks
>
> Denghui Dong has updated the pull request incrementally with one additional commit since the last revision:
> 
>   comment

Thanks for adding the comment!

src/hotspot/share/c1/c1_IR.cpp line 315:

> 313: // Some instructions may introduce more than one edge between two blocks.
> 314: // By checking if the current 'to' block sets critical_edge_split_flag
> 315: // (all new blocks set this flag) to avoid repeated processing.

Suggestion:

// (all new blocks set this flag) we can avoid repeated processing.

-------------

Marked as reviewed by chagedorn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17674#pullrequestreview-1902804060
PR Review Comment: https://git.openjdk.org/jdk/pull/17674#discussion_r1503807534