RFR: 8325746: Refactor Loop Unswitching code [v10]

Christian Hagedorn chagedorn at openjdk.org
Tue Feb 27 09:31:28 UTC 2024


On Mon, 26 Feb 2024 11:53:16 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add additional run
>
> test/hotspot/jtreg/compiler/loopopts/TestBaseCountedEndLoopUnswitchCandidate.java line 32:
> 
>> 30:  *                   -Xcomp -XX:LoopMaxUnroll=0 -XX:-UseLoopPredicate -XX:-RangeCheckElimination
>> 31:  *                   compiler.loopopts.TestBaseCountedEndLoopUnswitchCandidate
>> 32:  * @run main/othervm compiler.loopopts.TestBaseCountedEndLoopUnswitchCandidate
> 
> Suggestion:
> 
>  * @run driver compiler.loopopts.TestBaseCountedEndLoopUnswitchCandidate
> 
> Nit: now that you have no arguments

As discussed offline, changing this to `@run main` to enable the CI to pass additional flags which would not otherwise be possible with `driver`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17842#discussion_r1503915064


More information about the hotspot-compiler-dev mailing list