RFR: 8326135: Enhance adlc to report unused operands [v4]

Vladimir Ivanov vlivanov at openjdk.org
Wed Feb 28 03:25:56 UTC 2024


On Wed, 28 Feb 2024 03:01:20 GMT, kuaiwei <duke at openjdk.org> wrote:

>> src/hotspot/share/adlc/archDesc.cpp line 27:
>> 
>>> 25: 
>>> 26: // archDesc.cpp - Internal format for architecture definition
>>> 27: #include <unordered_set>
>> 
>> Even though it's not hotspot code per se (but a tool used during build), it'll be the first usage of C++ STL in the hotspot code base.
>> 
>> HotSpot Coding Style [1] clearly states "Avoid using the C++ Standard Library." 
>> 
>> @kimbarrett what are your thoughts on it?
>> 
>> [1] https://github.com/openjdk/jdk/blob/master/doc/hotspot-style.md
>
> @iwanowww Can you check if I can use STL here?

Nobody spoke up against, so I'm fine with using it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17910#discussion_r1505304417


More information about the hotspot-compiler-dev mailing list