RFR: 8320725: C2: Add "requires_strict_order" flag for floating-point add-reduction

[Bhavana Kilambi]

On Wed, 28 Feb 2024 08:46:28 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Before this patch, the `ReductionNode` is strict-ordered and the `UnorderedReductionNode` is unordered. If we want an unordered reduction node, we just extends `UnorderedReductionNode` instead of `ReductionNode`. Now you think every concrete node object should has the right to judge whether it is strict-ordered or not by itself (using the method `requires_strict_order`). If my understanding is right, this patch is a nice refactor. Some concrete comments are shown below.

Hi, thanks for your review. You are correct. With this patch, all reduction type nodes (whether ordered or unordered) can decide if they are ordered/unordered based on 'requires_strict_order' method. In addition to that, they can also define a field - 'requires_strict_order' like in the floating-point add reduction node definitions in case there are multiple paths where a specific node can be either ordered or unordered (instead of returning a fixed true/false value). I will make changes you suggested and update patch accordingly. Thanks again!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18034#issuecomment-1970925758