RFR: 8322743: C2: prevent lock region elimination in OSR compilation [v3]

[Vladimir Kozlov]

On Thu, 29 Feb 2024 16:34:47 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/locks/TestLocksInOSR.java line 28:
>> 
>>> 26:  * @bug 8322743
>>> 27:  * @summary EA incorrectly marks locks for elimination for escaped object which comes from Interpreter in OSR compilation.
>>> 28:  * @run main/othervm -XX:-TieredCompilation -Xcomp -XX:CompileCommand=compileonly,TestLocksInOSR*::* -XX:CompileCommand=quiet TestLocksInOSR
>> 
>> Suggestion:
>> 
>>  * @run main/othervm -XX:-TieredCompilation -Xcomp -XX:CompileCommand=compileonly,TestLocksInOSR*::* -XX:CompileCommand=quiet TestLocksInOSR
>>  * @run main/othervm -XX:CompileCommand=compileonly,TestLocksInOSR*::* -XX:CompileCommand=quiet TestLocksInOSR
>> 
>> The second run would allow more external flags to have an effect.
>> But optional.
>> Do you need the `-XX:CompileCommand=quiet`?
>
>> Do you need the -XX:CompileCommand=quiet?
> 
> `CompileCommand`, which exclude all compilations except specified ones, significantly pollutes output when I debugging testing with `PrintCompilation`. Especially in combination with `-Xcomp`.

> The second run would allow more external flags to have an effect.

I think second run needs to be without any flags. `compileonly` was used only to limit compilations for `-Xcomp`.
I will ad such run. But I would need to test it again :(

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17331#discussion_r1507876364