RFR: 8322758: Eliminate -Wparentheses warnings in C2 code

Vladimir Kozlov kvn at openjdk.org
Tue Jan 2 20:08:37 UTC 2024


On Fri, 29 Dec 2023 02:01:08 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this change to eliminate some -Wparentheses warnings.  In most
> cases, this involved simply adding a few parentheses to make some implicit
> operator precedence explicit.
> 
> In PhaseIdealLoop::rc_predicate, I also added a comment describing the test
> being performed, since it didn't seem obvious even with the additional
> parentheses.
> 
> Testing: mach5 tier1
> 
> Also ran mach5 tier1 with these changes in conjunction enabling -Wparentheses
> and other changes needed to make that work.

Looks good to me.

-------------

Marked as reviewed by kvn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17199#pullrequestreview-1800947505


More information about the hotspot-compiler-dev mailing list