RFR: 8322758: Eliminate -Wparentheses warnings in C2 code [v3]
Kim Barrett
kbarrett at openjdk.org
Tue Jan 2 22:36:23 UTC 2024
> Please review this change to eliminate some -Wparentheses warnings. In most
> cases, this involved simply adding a few parentheses to make some implicit
> operator precedence explicit.
>
> In PhaseIdealLoop::rc_predicate, I also added a comment describing the test
> being performed, since it didn't seem obvious even with the additional
> parentheses.
>
> Testing: mach5 tier1
>
> Also ran mach5 tier1 with these changes in conjunction enabling -Wparentheses
> and other changes needed to make that work.
Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
- Merge branch 'master' into c2-wparentheses
- update copyrights for 2024
- fix -Wparentheses warnings in C2 code
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/17199/files
- new: https://git.openjdk.org/jdk/pull/17199/files/abacbe0e..2ad3798d
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=17199&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=17199&range=01-02
Stats: 863 lines in 58 files changed: 610 ins; 44 del; 209 mod
Patch: https://git.openjdk.org/jdk/pull/17199.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/17199/head:pull/17199
PR: https://git.openjdk.org/jdk/pull/17199
More information about the hotspot-compiler-dev
mailing list