RFR: 8320128: Clean up Parse constructor for OSR [v3]

[Xin Liu]

On Wed, 3 Jan 2024 17:03:56 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Xin Liu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Use atomic logline and resume #ifdef ASSERT.
>>  - Merge branch 'master' into JDK-8320128
>>  - Update according to reviewer's feedback.
>>  - 8320128: Clean up Parse constructor for OSR
>
> src/hotspot/share/opto/parse1.cpp line 529:
> 
>> 527:   }
>> 528: 
>> 529: #ifdef ASSERT
> 
> I think the goal for this `#ifdef` block is to eliminate even the `if (depth() == 1)` in product builds. Yes, most of the code is dead, but it is safer not to rely on it. Leave it as is.

I tried to improve readability by reducing macros. okay. I bring it back.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16669#discussion_r1440895697